Skip to content

Removed Muyin Zheng from Home Unite Us page #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-will-gillis merged 1 commit into from
May 15, 2025
Merged

Removed Muyin Zheng from Home Unite Us page #8127

t-will-gillis merged 1 commit into from
May 15, 2025

Conversation

@michael-4
Copy link
Member

@michael-4 michael-4 commented May 13, 2025 •
edited
Loading

Fixes #7483

What changes did you make?

  • Removed Muyin Zheng and corresponding data from Home Unite Us page.
  • This pull request is a redo of an old pull request which accidentally reintroduced deleted info
  • previous pull request is linked here: Home unite us remove muyin zheng #8071

Why did you make the changes (we will use this info to test)?

  • To keep the list of members up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

![image]
Screen Shot 2025-05-13 at 4 16 19 PM

Visuals after changes are applied

![image]
Screen Shot 2025-05-13 at 4 19 47 PM

@github-actions
Copy link

github-actions bot commented May 13, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b michael-4-remove-muyin-zheng-8071 gh-pages
git pull https://github.com/michael-4/website.git remove-muyin-zheng-8071

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 13, 2025
@michael-4 michael-4 mentioned this pull request May 13, 2025
Closed
5 tasks
t-will-gillis
t-will-gillis requested changes May 14, 2025
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michael-4 - Thanks for resubmitting this PR. The branches are good, there are before and after screenshots, and the code change is clean now. Looks good- just have a couple requests.

  • Please change the "Fixes: " reference to be the original issue instead of the previous PR
  • For "Why did you make the changes...", the answer that you had on the previous PR is what you want here, i.e. "To keep the list of members up to date"- this is the reason for the issue.
  • For the "CodeQL Alerts", you do not have any so please check "I have checked this PR for CodeQL alerts and none were found."

Almost there- thanks for working on this

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board May 14, 2025
@michael-4
Copy link
Member Author

michael-4 commented May 15, 2025

Hi @t-will-gillis thanks again for your continued feedback! I've made the changes you said, hopefully it's all good now

andyvu923
andyvu923 approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@andyvu923 andyvu923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michael-4 , the PR looks good to me! The code changes are clean and relevant, the before and after pictures are provided and correct, and all the information in the PR seems correct as well. PR Approved 👍👍

t-will-gillis
t-will-gillis approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michael-4 - thank you for making the edits, and thank you for working on this issue. Everything looks great.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 15, 2025
@t-will-gillis t-will-gillis merged commit c840acb into hackforla:gh-pages May 15, 2025
9 checks passed
@michael-4 michael-4 mentioned this pull request May 20, 2025
Open
@t-will-gillis t-will-gillis mentioned this pull request Aug 3, 2025
Open
@HackforLABot HackforLABot mentioned this pull request Aug 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-will-gillis t-will-gillis t-will-gillis approved these changes

+1 more reviewer

@andyvu923 andyvu923 andyvu923 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Remove Muyin Zheng

3 participants

@michael-4 @t-will-gillis @andyvu923